slack-vitess-r15.0.5: backport upstream PR #11968#256
Merged
timvaillancourt merged 2 commits intoslack-vitess-r15.0.5from Mar 15, 2024
Merged
slack-vitess-r15.0.5: backport upstream PR #11968#256timvaillancourt merged 2 commits intoslack-vitess-r15.0.5from
slack-vitess-r15.0.5: backport upstream PR #11968#256timvaillancourt merged 2 commits intoslack-vitess-r15.0.5from
Conversation
* Pass BUILD_GIT_BRANCH and BUILD_GIT_REV env into docker build Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Fix bootstrap version Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Fix bootstrap version, again Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Fix ws Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Co-authored-by: Florent Poinsard <florent.poinsard@outlook.fr>
tanjinx
approved these changes
Mar 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR backports v16 PR vitessio#11968 that fixes build-related metrics/vars so the git branch, commit, etc is displayed correctly
We currently rely on this backport in v12 + v14. The debt is payed down in v16
Related Issue(s)
vitessio#11968
Checklist
Deployment Notes